[PATCH] D28312: NewGVN: Fix PR 31501.

[Davide Italiano via Phabricator via llvm-commits]

davide added a comment.

LGTM again, thanks for taking care of the post commit comments.



================
Comment at: llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp:1998-1999
           }
-          if (Member && isa<Constant>(Member))
-            assert(isa<Constant>(CC->RepLeader));
 
----------------
dberlin wrote:
> davide wrote:
> > Why this assertion doesn't hold anymore?
>   if (isa<ConstantExpression>(E))
>         assert(isa<Constant>(EClass->RepLeader) &&
>                "Any class with a constant expression should have a "
>                "constant leader");
> 
> 
> verifies it now during congruence finding
Cool! I missed it :(


Repository:
  rL LLVM

https://reviews.llvm.org/D28312