[PATCH] D28359: [compiler-rt] Use common static library for sanitizer_common.

Filipe Cabecinhas via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 15:58:19 PST 2017


But most sanitisers can't be combined.
When they can be combined, you end up with a "main" one, and secondary ones
(asan + lsan + ubsan or tsan + ubsan).
By having a library for each, you at most save a tiny bit on the clang side
at the expense of tracking more libraries which can end up being mismatched.

Thank you,

 Filipe

On Thu, 5 Jan 2017 at 23:30, Marcos Pividori via Phabricator <
reviews at reviews.llvm.org> wrote:

> mpividori added a comment.
>
>
>
> @filcab
>
> Yes, now it works that way. Is that what we want?
>
> I mean, we could include all the sanitizers in only one unique run time
> library, or we can try to keep them separated in different independent
> libraries and only include them when necessary. Both approaches are valid.
>
> Now, I think there is a bit of everything, which is confusing.
>
> For some sanitizers combinations we include them in the same library, for
> others we keep them separated.
>
> I was trying to understand, is there any reason why we keep ubsan and leak
> sanitizers inside asan library?
>
>
>
>
>
> Repository:
>
>   rL LLVM
>
>
>
> https://reviews.llvm.org/D28359
>
>
>
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170105/610640bb/attachment.html>


More information about the llvm-commits mailing list