[llvm] r290755 - [NewGVN] Remove unneeded newline from assertion message.

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 30 15:55:05 PST 2016


Why 100? It seems weird to have an `assert` against a magic number like
this; presumably the assert would fail if the magic number were 2 or
something? What makes 100 "impossible"? It would be good to have this in a
comment.

-- Sean Silva

On Fri, Dec 30, 2016 at 7:01 AM, Davide Italiano via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: davide
> Date: Fri Dec 30 09:01:17 2016
> New Revision: 290755
>
> URL: http://llvm.org/viewvc/llvm-project?rev=290755&view=rev
> Log:
> [NewGVN] Remove unneeded newline from assertion message.
>
> Modified:
>     llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp
>
> Modified: llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/
> Transforms/Scalar/NewGVN.cpp?rev=290755&r1=290754&r2=290755&view=diff
> ============================================================
> ==================
> --- llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp (original)
> +++ llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp Fri Dec 30 09:01:17 2016
> @@ -1281,7 +1281,7 @@ void NewGVN::updateProcessedCount(Value
>    } else {
>      ProcessedCount[V] += 1;
>      assert(ProcessedCount[V] < 100 &&
> -           "Seem to have processed the same Value a lot\n");
> +           "Seem to have processed the same Value a lot");
>    }
>  #endif
>  }
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161230/7259c0ee/attachment.html>


More information about the llvm-commits mailing list