<div dir="ltr">Why 100? It seems weird to have an `assert` against a magic number like this; presumably the assert would fail if the magic number were 2 or something? What makes 100 "impossible"? It would be good to have this in a comment.<div><div><br></div><div>-- Sean Silva</div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 30, 2016 at 7:01 AM, Davide Italiano via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: davide<br>
Date: Fri Dec 30 09:01:17 2016<br>
New Revision: 290755<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=290755&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=290755&view=rev</a><br>
Log:<br>
[NewGVN] Remove unneeded newline from assertion message.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/<wbr>Scalar/NewGVN.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/<wbr>Scalar/NewGVN.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp?rev=290755&r1=290754&r2=290755&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Transforms/Scalar/NewGVN.cpp?<wbr>rev=290755&r1=290754&r2=<wbr>290755&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Transforms/<wbr>Scalar/NewGVN.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/<wbr>Scalar/NewGVN.cpp Fri Dec 30 09:01:17 2016<br>
@@ -1281,7 +1281,7 @@ void NewGVN::updateProcessedCount(<wbr>Value<br>
   } else {<br>
     ProcessedCount[V] += 1;<br>
     assert(ProcessedCount[V] < 100 &&<br>
-           "Seem to have processed the same Value a lot\n");<br>
+           "Seem to have processed the same Value a lot");<br>
   }<br>
 #endif<br>
 }<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>