[PATCH] D28116: [NewGVN] Reduce code duplication for load/store equality

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 27 11:18:02 PST 2016


s/common base/common base higher than basicexpression/

On Tue, Dec 27, 2016 at 11:17 AM, Daniel Berlin <dberlin at dberlin.org> wrote:

> Oh that's right, they don't share a common base.
>
> No, just template it.
> We are going to override this again anyway when it comes to
> CoercibleLoadExpression.
>
>
>
> On Tue, Dec 27, 2016 at 9:07 AM, Davide Italiano via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> davide added a comment.
>>
>> In https://reviews.llvm.org/D28116#631112, @dberlin wrote:
>>
>> > Actually, they are identical, aren't they?
>> >  I don't think you even need to template it
>>
>>
>> I can use the closest base to {Load,Store}Expression, that is
>> `BasicExpression` instead of the template but that has no
>> `getDefiningAccess()`, do you prefer me to move the function there instead
>> of templating?
>>
>>
>> https://reviews.llvm.org/D28116
>>
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161227/4c21ad22/attachment.html>


More information about the llvm-commits mailing list