<div dir="ltr">s/common base/common base higher than basicexpression/<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 27, 2016 at 11:17 AM, Daniel Berlin <span dir="ltr"><<a href="mailto:dberlin@dberlin.org" target="_blank">dberlin@dberlin.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Oh that's right, they don't share a common base.<div><br></div><div>No, just template it.</div><div>We are going to override this again anyway when it comes to CoercibleLoadExpression.</div><div><br><div><br></div></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 27, 2016 at 9:07 AM, Davide Italiano via Phabricator <span dir="ltr"><<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">davide added a comment.<br>
<span><br>
In <a href="https://reviews.llvm.org/D28116#631112" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2811<wbr>6#631112</a>, @dberlin wrote:<br>
<br>
> Actually, they are identical, aren't they?<br>
>  I don't think you even need to template it<br>
<br>
<br>
</span>I can use the closest base to {Load,Store}Expression, that is `BasicExpression` instead of the template but that has no `getDefiningAccess()`, do you prefer me to move the function there instead of templating?<br>
<br>
<br>
<a href="https://reviews.llvm.org/D28116" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2811<wbr>6</a><br>
<br>
<br>
<br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>