[llvm] r290596 - Change a std::vector to SmallVector in NewGVN

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 27 11:16:26 PST 2016


No, it's just reducing changes from the branch where they are small and
"obviously" correct.


On Tue, Dec 27, 2016 at 3:39 AM, Davide Italiano <davide at freebsd.org> wrote:

> On Tue, Dec 27, 2016 at 1:20 AM, Daniel Berlin via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > Author: dannyb
> > Date: Tue Dec 27 03:20:36 2016
> > New Revision: 290596
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=290596&view=rev
> > Log:
> > Change a std::vector to SmallVector in NewGVN
> >
> > Modified:
> >     llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp
> >
> > Modified: llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp
> > URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/
> Transforms/Scalar/NewGVN.cpp?rev=290596&r1=290595&r2=290596&view=diff
> > ============================================================
> ==================
> > --- llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp (original)
> > +++ llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp Tue Dec 27 03:20:36 2016
> > @@ -227,7 +227,7 @@ class NewGVN : public FunctionPass {
> >    // DFS info.
> >    DenseMap<const BasicBlock *, std::pair<int, int>> DFSDomMap;
> >    DenseMap<const Value *, unsigned> InstrDFS;
> > -  std::vector<Value *> DFSToInstr;
> > +  SmallVector<Value *, 32> DFSToInstr;
> >
>
> Thanks. Out of curiosity, are you seeing any speedup from this change?
>
> --
> Davide
>
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161227/83b825eb/attachment.html>


More information about the llvm-commits mailing list