<div dir="ltr">No, it's just reducing changes from the branch where they are small and "obviously" correct.<div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 27, 2016 at 3:39 AM, Davide Italiano <span dir="ltr"><<a href="mailto:davide@freebsd.org" target="_blank">davide@freebsd.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Tue, Dec 27, 2016 at 1:20 AM, Daniel Berlin via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: dannyb<br>
> Date: Tue Dec 27 03:20:36 2016<br>
> New Revision: 290596<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=290596&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=290596&view=rev</a><br>
> Log:<br>
> Change a std::vector to SmallVector in NewGVN<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/Transforms/<wbr>Scalar/NewGVN.cpp<br>
><br>
> Modified: llvm/trunk/lib/Transforms/<wbr>Scalar/NewGVN.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp?rev=290596&r1=290595&r2=290596&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Transforms/Scalar/NewGVN.cpp?<wbr>rev=290596&r1=290595&r2=<wbr>290596&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/lib/Transforms/<wbr>Scalar/NewGVN.cpp (original)<br>
> +++ llvm/trunk/lib/Transforms/<wbr>Scalar/NewGVN.cpp Tue Dec 27 03:20:36 2016<br>
> @@ -227,7 +227,7 @@ class NewGVN : public FunctionPass {<br>
>    // DFS info.<br>
>    DenseMap<const BasicBlock *, std::pair<int, int>> DFSDomMap;<br>
>    DenseMap<const Value *, unsigned> InstrDFS;<br>
> -  std::vector<Value *> DFSToInstr;<br>
> +  SmallVector<Value *, 32> DFSToInstr;<br>
><br>
<br>
</span>Thanks. Out of curiosity, are you seeing any speedup from this change?<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Davide<br>
<br>
"There are no solved problems; there are only problems that are more<br>
or less solved" -- Henri Poincare<br>
</font></span></blockquote></div><br></div>