[PATCH] D27701: [lit] Fix discovery test on Windows

Brian Gesiak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 18 19:38:53 PST 2016

modocache added a comment.

That makes sense, thanks for the feedback @delcypher.

Is there a strong reason you'd prefer `/` in all cases, though?

I ask because it seems more correct to output paths using each platform's native path separators. Yes, we could modify the logic in `LitConfig.py` to use `"/".join()` instead of `os.path.join()`, and replace `\` with `/` in the paths we output, but that seems like additional complexity for what is, in my opinion, marginal benefit. True, this particular test is uglier because of the difference in path separators, but this and https://reviews.llvm.org/D27908 are the only two tests that need to be modified for this reason. So personally, I think it makes more sense to change the tests, than it does to change lit's behavior.



More information about the llvm-commits mailing list