[PATCH] D27701: [lit] Fix discovery test on Windows

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 18 02:27:09 PST 2016


delcypher added a comment.

In https://reviews.llvm.org/D27701#621835, @modocache wrote:

> Actually, I'm not sure this can be fixed in `LitConfig.py`. I could force the lit output to always use Unix path separators, even on Windows, but that would be inconvenient for Windows developers that want to copy and paste the paths.
>
> Still, matching `SEP` like this is gross. Do any reviewers feel strongly about this? Would it be better if I added a way to match path separators to FileCheck itself?


If it's possible I would prefer always using Unix path separators. `/` is supported as a path separator on Windows (in some cases) . E.g. in `cmd.exe` I can type

  C:\> cd c:/Users/foo
  c:\Users\foo> 

and the command works correctly. It doesn't always work however so we need to test if lit would perform as expected in the "copy and paste test paths" scenario.


https://reviews.llvm.org/D27701





More information about the llvm-commits mailing list