[PATCH] D27712: [ELF] - Do not crash when move location counter backward.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 15 09:50:56 PST 2016

ruiu added a comment.

I think I'm not a big fan of int-ish type because even though they look like int and behave like int, they are different from int at a lot of places. That increases complexity in a subtle way. Currently, you can read our code without too much previous knowledge because we do not use magic C++ provides that much. If we need an overflow check, I want something more explicit. For example, I'd rather use uint128_t or something to avoid overflow during computation and check everything later. But we don't have to do that now.



More information about the llvm-commits mailing list