[PATCH] D27712: [ELF] - Do not crash when move location counter backward.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 23:41:30 PST 2016

grimar added a comment.

In https://reviews.llvm.org/D27712#623084, @ruiu wrote:

> LGTM. I'm not convinced that https://reviews.llvm.org/D25279 is worth its complexity

May be. Though I think we should be able to replace uint64_t Dot to "some checked type" Dot,
and that can solve all possible overflow issues once with just a this local change.
It looks convinent to have such overflow detector class, may be we can have one in llvm. Not sure here.



More information about the llvm-commits mailing list