[PATCH] D25821: [ELF] - Partial support of --gdb-index command line option (Part 2).

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: ELF/GdbIndex.h:29
+
+template <class ELFT> class GdbIndexBuilder : public LoadedObjectInfo {
+  typedef typename ELFT::uint uintX_t;
----------------
Comment what this is?


================
Comment at: ELF/GdbIndex.h:38
+  GdbIndexBuilder(InputSection<ELFT> *DebugInfoSec);
+
+  std::vector<std::pair<uintX_t, uintX_t>> readCuList();
----------------
Please add Doxygen comments too all these functions.


================
Comment at: ELF/GdbIndex.h:39
+
+  std::vector<std::pair<uintX_t, uintX_t>> readCuList();
+  std::vector<AddressEntry<ELFT>> readAddressArea(size_t CurrentCU);
----------------
Up to taste, but I think I would spell this `readCUList`.


https://reviews.llvm.org/D25821