[PATCH] D25821: [ELF] - Partial support of --gdb-index command line option (Part 2).

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 09:01:02 PST 2016

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Small comments inline.

Comment at: ELF/GdbIndex.h:23
+template <class ELFT> struct AddressEntry {
+  InputSectionBase<ELFT> *Section; // Section.
+  uint64_t LowAddress;             // The low address.
These comments are not useful, they just repeat the name of the fields. Can you instead add a doxygen comment that describes the purpose of the struct on top?


More information about the llvm-commits mailing list