[PATCH] D26224: NewGVN

[Daniel Berlin via llvm-commits]

Davide, you should s/~0/EmptyKey/
and s/~1/TombstoneKey/

On Tue, Dec 13, 2016 at 7:33 PM, Vedant Kumar via Phabricator <
reviews at reviews.llvm.org> wrote:

> vsk added inline comments.
>
>
> ================
> Comment at: include/llvm/Transforms/Scalar/GVNExpression.h:63
> +      return false;
> +    if (getOpcode() == ~0U || getOpcode() == ~1U)
> +      return true;
> ----------------
> Could you add a brief comment explaining the significance of the ~0U, ~1U,
> and ~2U opcodes before using them? In particular, it would be nice to
> explain why we don't look at 'Other' when Opcode is in {~0,~1}.
>
>
> https://reviews.llvm.org/D26224
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161213/aa1cdd2a/attachment.html>