[PATCH] D26224: NewGVN

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: include/llvm/Transforms/Scalar/GVNExpression.h:63
+      return false;
+    if (getOpcode() == ~0U || getOpcode() == ~1U)
+      return true;
----------------
Could you add a brief comment explaining the significance of the ~0U, ~1U, and ~2U opcodes before using them? In particular, it would be nice to explain why we don't look at 'Other' when Opcode is in {~0,~1}.


https://reviews.llvm.org/D26224