[PATCH] D27579: [libFuzzer] Diff 19 - Automatically link with Windows library.

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 8 10:42:43 PST 2016


If in the future there are more functions we need from that library then I
might be convinced, but pulling in a whole library (which is a high level
user library on top of that) for one function doesn't seem worth it.  What
do you think Adrian?

On Thu, Dec 8, 2016 at 10:41 AM Marcos Pividori via Phabricator <
reviews at reviews.llvm.org> wrote:

> mpividori added a comment.
>
> @zturner Yes, we can implement it. I considered that before, but as there
> are many cases to be considered: relative paths vs full paths, using UNC or
> disk designators, etc, I thought it would be better to use Win Api instead
> of implementing it from scratch. I didn't realize that it is implemented in
> the Support library. I will read that code.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D27579
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161208/4a89ab22/attachment.html>


More information about the llvm-commits mailing list