[PATCH] D26734: [ELF] Don't replace path separators on *NIX

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 16 11:32:12 PST 2016


ruiu accepted this revision.
ruiu added a reviewer: ruiu.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/ELF/reproduce-backslash.s:5
+# legal for a filename to contain backslashes.
+# RUN: rm -rf %t.dir
+# RUN: mkdir -p %t.dir/build
----------------
davide wrote:
> davide wrote:
> > ruiu wrote:
> > > ruiu wrote:
> > > > I don't think you need to to create a directory.
> > > And I want to avoid "rm -rf" in general because one mistake can really be disastrous (not only one person but everybody who checks out a buggy test file and run it).
> > What's the alternative?  The directory might be non-empty, so `rmdir` doesn't work. We can remove the `rm` comment altogether, but the risk is leaving random test output around.
> I mean, in this case is possible (as I did in the new patch), but in general I doubt we can avoid calling `rm -rf`.
There might be a case in which we really need to run "rm -rf", but before writing that command, I'll do whatever I can do to avoid it. That's what I mean.


https://reviews.llvm.org/D26734





More information about the llvm-commits mailing list