[PATCH] D26734: [ELF] Don't replace path separators on *NIX

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 16 11:29:27 PST 2016


davide added inline comments.


================
Comment at: test/ELF/reproduce-backslash.s:5
+# legal for a filename to contain backslashes.
+# RUN: rm -rf %t.dir
+# RUN: mkdir -p %t.dir/build
----------------
davide wrote:
> ruiu wrote:
> > ruiu wrote:
> > > I don't think you need to to create a directory.
> > And I want to avoid "rm -rf" in general because one mistake can really be disastrous (not only one person but everybody who checks out a buggy test file and run it).
> What's the alternative?  The directory might be non-empty, so `rmdir` doesn't work. We can remove the `rm` comment altogether, but the risk is leaving random test output around.
I mean, in this case is possible (as I did in the new patch), but in general I doubt we can avoid calling `rm -rf`.


https://reviews.llvm.org/D26734





More information about the llvm-commits mailing list