[PATCH] D26617: add FreeBSD elf-core test

Pavel Labath via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 15 01:40:08 PST 2016


labath added a comment.

Looks good. If we're going to put freebsd tests in the same file, we should rename the test file as well.



================
Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py:21-27
     _i386_pid = 32306
     _x86_64_pid = 32259
     _s390x_pid = 1045
 
     _i386_regions = 4
     _x86_64_regions = 5
     _s390x_regions = 2
----------------
emaste wrote:
> We'll probably want to rework these into a table of some sort, similar to
> ```
> linux-i386, 32306, 32306, 4,
> linux-x86_64, 32259, 32259, 5,
> freebsd-x86_64, 0, 100283, 2,
> ```
Sounds good. Personally, I'd go for a two level structure `data.linux_i386.pid` or something like that.


https://reviews.llvm.org/D26617





More information about the llvm-commits mailing list