[PATCH] D26617: add FreeBSD elf-core test

Ed Maste via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 14 09:50:05 PST 2016


emaste added inline comments.


================
Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py:21-27
     _i386_pid = 32306
     _x86_64_pid = 32259
     _s390x_pid = 1045
 
     _i386_regions = 4
     _x86_64_regions = 5
     _s390x_regions = 2
----------------
We'll probably want to rework these into a table of some sort, similar to
```
linux-i386, 32306, 32306, 4,
linux-x86_64, 32259, 32259, 5,
freebsd-x86_64, 0, 100283, 2,
```


================
Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py:29
 
+    _freebsd_x86_64_pid = 0
+    _freebsd_x86_64_tid = 100283
----------------
I probably need to submit a PR for this (not extracting the pid from FreeBSD ELF cores) and reference it in a comment.


https://reviews.llvm.org/D26617





More information about the llvm-commits mailing list