Any objections to running clang-format in include/llvm/Support/ELF.h?

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 14 12:53:55 PST 2016


Fine with me. I'm in favor of it, too.

On Mon, Nov 14, 2016 at 12:45 PM, Davide Italiano via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> On Mon, Nov 14, 2016 at 12:34 PM, Rafael EspĂ­ndola via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > The main difference will be that some enum definitions will go from
> >
> > long_val = 42,    // comment
> > val      = 42,    // comment
> >
> > to
> >
> > long_val = 42,    // comment
> > val = 43,         // comment
> >
> > I like the aligned =, but it is somewhat annoying to have one file
> > with a different style.
> >
> > Cheers,
> > Rafael
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
> No objections (actually in favour of).
> I have a large'ish patch converting from ErrorOr<> to Expected<>, so
> reformatting will cause a bit of merge pain to me.
> If you want, I can take care of that once I'm done with the patch?
> Otherwise I'll bite the bullet and resolve the conflicts.
>
> --
> Davide
>
> --
> Davide
>
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161114/a376262e/attachment.html>


More information about the llvm-commits mailing list