<div dir="ltr">Fine with me. I'm in favor of it, too.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 14, 2016 at 12:45 PM, Davide Italiano via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Mon, Nov 14, 2016 at 12:34 PM, Rafael Espíndola via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> The main difference will be that some enum definitions will go from<br>
><br>
> long_val = 42,    // comment<br>
> val      = 42,    // comment<br>
><br>
> to<br>
><br>
> long_val = 42,    // comment<br>
> val = 43,         // comment<br>
><br>
> I like the aligned =, but it is somewhat annoying to have one file<br>
> with a different style.<br>
><br>
> Cheers,<br>
> Rafael<br>
</div></div>> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br>
No objections (actually in favour of).<br>
I have a large'ish patch converting from ErrorOr<> to Expected<>, so<br>
reformatting will cause a bit of merge pain to me.<br>
If you want, I can take care of that once I'm done with the patch?<br>
Otherwise I'll bite the bullet and resolve the conflicts.<br>
<br>
--<br>
Davide<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Davide<br>
<br>
"There are no solved problems; there are only problems that are more<br>
or less solved" -- Henri Poincare<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</font></span></blockquote></div><br></div>