[PATCH] D26567: Improve DWARF parsing speed by improving DWARFAbbreviationDeclaration

Greg Clayton via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 14 08:39:53 PST 2016


clayborg added a comment.

In https://reviews.llvm.org/D26567#594381, @probinson wrote:

> So the idea is that you don't always have a Unit when you're parsing the abbreviations?  That's mildly counter-intuitive.  If you have a Unit then you know version and format up front, and you can just calculate the fixed sizes without having to remember how many of which special cases you found.  When would you be doing this without a Unit available?


All DWARF that we deal with in Mach-O at Apple have one abbreviation table that is shared for all compile units. Not sure if this is how things end up being in ELF DWARF files, but our tools end up having one abbreviation table for all compile units.


https://reviews.llvm.org/D26567





More information about the llvm-commits mailing list