[PATCH] D26567: Improve DWARF parsing speed by improving DWARFAbbreviationDeclaration

[Greg Clayton via llvm-commits]

clayborg added a comment.

In https://reviews.llvm.org/D26567#594381, @probinson wrote:

> So the idea is that you don't always have a Unit when you're parsing the abbreviations?  That's mildly counter-intuitive.  If you have a Unit then you know version and format up front, and you can just calculate the fixed sizes without having to remember how many of which special cases you found.  When would you be doing this without a Unit available?


I thought this was better than assuming all DWARFUnits would have the same version, DWARF32/DWARF64, and address size. I could always parse the first DWARFUnit and use that unit's version, address size and 32/64 to calculate things, but that seems like more of a hack.


https://reviews.llvm.org/D26567