[PATCH] D26023: [PowerPC] Improvements for BUILD_VECTOR Vol. 3

Kit Barton via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 9 12:32:54 PST 2016


kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.

One minor question, more for my own curiosity, that we can likely address offline. Aside from that, LGTM.



================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:10678
+                               LDL->getAlignment());
+    std::vector<int> Ops;
+    for (int i = N->getNumOperands() - 1; i >= 0; i--)
----------------
Any reason for a std::vector vs a SmallVector? 


Repository:
  rL LLVM

https://reviews.llvm.org/D26023





More information about the llvm-commits mailing list