[PATCH] D26023: [PowerPC] Improvements for BUILD_VECTOR Vol. 3

Nemanja Ivanovic via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 10 07:30:42 PST 2016


nemanjai added inline comments.


================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:10678
+                               LDL->getAlignment());
+    std::vector<int> Ops;
+    for (int i = N->getNumOperands() - 1; i >= 0; i--)
----------------
kbarton wrote:
> Any reason for a std::vector vs a SmallVector? 
That's a good point. The SmallVector is a better choice here. I'll change it prior to comitting.


Repository:
  rL LLVM

https://reviews.llvm.org/D26023





More information about the llvm-commits mailing list