[PATCH] D26199: [ELF] - Implemented --build-id=tree

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 2 02:40:53 PDT 2016


>> On Tue, Nov 1, 2016 at 12:04 PM, Rafael EspĂ­ndola
>> <rafael.espindola at gmail.com> wrote:
>>>
>>> It might be better to have a distinct --threaded-hash option so that
>>> just enabling threads doesn't change the output, but I agree that we
>>> should add one option and have the existing implementations take it
>>> into consideration.
>>
>>
>> That's good point, we should generate the same hash with/without threads.
>> But we don't need a new option for that -- just compute a tree hash even if
>> threading is disabled.
>
>Interesting. With a large enough chunk it shouldn't impact performance
>too much in the non threaded case.
>
>Cheers,
>Rafael

Sounds good. I think we might also want to add config option for chunk size.

Also what does mean "tree" here then ? I mean originally (by gold) tree is
a N runs of MD5 + final run of SHA1. Do we want to use just the original algorithm
whole the time ?

George.


More information about the llvm-commits mailing list