[PATCH] D26199: [ELF] - Implemented --build-id=tree

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 12:51:25 PDT 2016


On 1 November 2016 at 15:26, Rui Ueyama <ruiu at google.com> wrote:
> On Tue, Nov 1, 2016 at 12:04 PM, Rafael EspĂ­ndola
> <rafael.espindola at gmail.com> wrote:
>>
>> It might be better to have a distinct --threaded-hash option so that
>> just enabling threads doesn't change the output, but I agree that we
>> should add one option and have the existing implementations take it
>> into consideration.
>
>
> That's good point, we should generate the same hash with/without threads.
> But we don't need a new option for that -- just compute a tree hash even if
> threading is disabled.

Interesting. With a large enough chunk it shouldn't impact performance
too much in the non threaded case.

Cheers,
Rafael


More information about the llvm-commits mailing list