[PATCH] D26042: Consolidate BumpPtrAllocators.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 11:13:25 PDT 2016

On Fri, Oct 28, 2016 at 10:58 AM, Mehdi AMINI <mehdi.amini at apple.com> wrote:

> mehdi_amini added inline comments.
> ================
> Comment at: ELF/Memory.h:31
> +extern llvm::BumpPtrAllocator BAlloc;
> +extern llvm::StringSaver Saver;
> +
> ----------------
> ruiu wrote:
> > mehdi_amini wrote:
> > > Global mutable state never seems like a good idea.
> > I disagree. It depends on what you are doing and what your program is.
> I believe that in an ecosystem where we want to be able to evolve and
> innovate, like the LLVM ecosystem, this prevents code reuse, modularity,
> and future innovation. This is just unacceptable technical debt.
> Again we had this debate about lld, but this is just another opportunity
> to express another strong disagreement with what's going on in lld.

I appreciate you review my patch, but your comment raises a vague concern
which doesn't have a justification. We do care about the LLVM ecosystem,
modularity and future innovation (I believe you would find LLD is *very*
hackable if you read the source code), and based on our experience and
knowledge with this codebase, we agreed that an arena allocator-ish memory
management will fit best.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161028/f0484429/attachment.html>

More information about the llvm-commits mailing list