[PATCH] D26042: Consolidate BumpPtrAllocators.
Mehdi AMINI via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 28 10:58:20 PDT 2016
mehdi_amini added inline comments.
Comment at: ELF/Memory.h:31
+extern llvm::BumpPtrAllocator BAlloc;
+extern llvm::StringSaver Saver;
> mehdi_amini wrote:
> > Global mutable state never seems like a good idea.
> I disagree. It depends on what you are doing and what your program is.
I believe that in an ecosystem where we want to be able to evolve and innovate, like the LLVM ecosystem, this prevents code reuse, modularity, and future innovation. This is just unacceptable technical debt.
Again we had this debate about lld, but this is just another opportunity to express another strong disagreement with what's going on in lld.
More information about the llvm-commits