[PATCH] D26045: [cfi] Fix weak functions handling.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 17:04:02 PDT 2016


pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM with nits



================
Comment at: lib/Transforms/IPO/LowerTypeTests.cpp:760
+  GV->setInitializer(
+      Constant::getNullValue(GV->getType()->getPointerElementType()));
+}
----------------
Nit: could be `GV->getValueType()`.


================
Comment at: lib/Transforms/IPO/LowerTypeTests.cpp:1077
   ObjectFormat = TargetTriple.getObjectFormat();
+  WeakInitializerFn = nullptr;
 }
----------------
Nit: this could be an in-class initializer.


Repository:
  rL LLVM

https://reviews.llvm.org/D26045





More information about the llvm-commits mailing list