[PATCH] D26045: [cfi] Fix weak functions handling.

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 16:30:59 PDT 2016


eugenis added inline comments.


================
Comment at: lib/Transforms/IPO/LowerTypeTests.cpp:766
+    if (auto *GV = dyn_cast<GlobalVariable>(U))
+      Out.push_back(GV);
+    else if (auto *C2 = dyn_cast<Constant>(U))
----------------
pcc wrote:
> Is this correctly handling the case where an initializer contains multiple references to a weak undef?
another good point!


Repository:
  rL LLVM

https://reviews.llvm.org/D26045





More information about the llvm-commits mailing list