[PATCH] D25927: [cfi] Implement cfi-icall using inline assembly.

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 13:01:33 PDT 2016

eugenis added inline comments.

Comment at: lib/Transforms/IPO/LowerTypeTests.cpp:669
+  SmallString<16> Name;
+  Mangler::getNameWithPrefix(Name, Dest->getName(), M.getDataLayout());
pcc wrote:
> Although I think it doesn't matter in this case, it would probably be better to use the overload that takes a `GlobalValue`.
That one is not static. It can assign temporary labels for unnamed globals, but to use that we would need to access the instance in TargetLoweringObjectFile, not create our own.



More information about the llvm-commits mailing list