[PATCH] D25927: [cfi] Implement cfi-icall using inline assembly.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 26 18:40:47 PDT 2016


pcc added inline comments.


================
Comment at: lib/Transforms/IPO/LowerTypeTests.cpp:669
+  SmallString<16> Name;
+  Mangler::getNameWithPrefix(Name, Dest->getName(), M.getDataLayout());
+
----------------
Although I think it doesn't matter in this case, it would probably be better to use the overload that takes a `GlobalValue`.


Repository:
  rL LLVM

https://reviews.llvm.org/D25927





More information about the llvm-commits mailing list