[PATCH] D25697: Make the LTO comdat api more symbol table friendly

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 22 11:27:32 PDT 2016


mehdi_amini added inline comments.


================
Comment at: lib/LTO/LTO.cpp:239
+      return make_error<StringError>("Unable to determine comdat of alias!",
+                                     inconvertibleErrorCode());
+  } else {
----------------
The error looks like the caller is not supposed to call this API under some circumstances, but it is not clear to me how it is supposed to figure, or recover.


https://reviews.llvm.org/D25697





More information about the llvm-commits mailing list