[PATCH] D25697: Make the LTO comdat api more symbol table friendly

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 22 11:26:10 PDT 2016

mehdi_amini added a comment.

There are no changes in llvm-lto2, that makes me worried on the coverage of these code path.

Comment at: include/llvm/LTO/LTO.h:188
+    // FIXME: We have to return Expected<int> because of the way aliases are
+    // implemented and the lack of a IR symbol table.
+    Expected<int> getComdatIndex() const;
The FIXME is not very clear "the way aliases are implemented" -> I have no idea what this is about.


More information about the llvm-commits mailing list