[PATCH] D25580: [PowerPC] Improve handling of BUILD_VECTOR nodes (integer results)

Andrea Di Biagio via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 21 10:41:51 PDT 2016

andreadb added a comment.

In https://reviews.llvm.org/D25580#576595, @nemanjai wrote:

> In https://reviews.llvm.org/D25580#576421, @andreadb wrote:
> > Hi Nemanja,


>> The other thing I have noticed is that no extra tests have been added by your patch. Given the amount of extra logic added by the patch, I have to admit that I was a bit surprised not to see any extra test coverage. Is it because the coverage for those features is already in the regression suite?
> I will certainly re-work this to try to split it up into a few patches. However, I'm not sure why you say there is no new test coverage. The test case "build-vector-tests.ll" is part of the patch and it is a completely new test case. I have a feeling that Phabricator has collapsed it in your view and you've just missed it.

You are right! Phabricator has just collapsed it. I should pay more attention to the "This file has a very large number of changes. Show file contents." messages.



More information about the llvm-commits mailing list