[PATCH] D25854: [lto] Kill undefined extern_weak declarations before opt

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 20 18:05:30 PDT 2016


mehdi_amini added inline comments.


================
Comment at: lib/LTO/LTO.cpp:346
       continue;
     if (Res.Prevailing && GV) {
       Keep.push_back(GV);
----------------
pcc wrote:
> I would have thought that you could keep track of the undefined symbols in a local variable here and RAUW them in a loop below. That way, you can avoid the global tracking. 
How do you address ThinLTO?

Which needs to be added to the patch BTW.


Repository:
  rL LLVM

https://reviews.llvm.org/D25854





More information about the llvm-commits mailing list