[PATCH] D25854: [lto] Kill undefined extern_weak declarations before opt

[Peter Collingbourne via llvm-commits]

pcc added inline comments.


================
Comment at: include/llvm/LTO/LTO.h:428
+
+      /// This global is undefined.
+      Undefined = -3u,
----------------
Do we need to track this globally?


================
Comment at: lib/LTO/LTO.cpp:346
       continue;
     if (Res.Prevailing && GV) {
       Keep.push_back(GV);
----------------
I would have thought that you could keep track of the undefined symbols in a local variable here and RAUW them in a loop below. That way, you can avoid the global tracking. 


Repository:
  rL LLVM

https://reviews.llvm.org/D25854