[PATCH] D25632: [LV] Sink scalar operands of predicated instructions

Gil Rapaport via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 10:20:15 PDT 2016

gilr accepted this revision.
gilr added a comment.
This revision is now accepted and ready to land.

LGTM with a nit (inline)

Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:4299
+      if (!I || I->mayHaveSideEffects() || !VectorLoop->contains(I) ||
+          I->getParent() == PredBB || isa<PHINode>(I))
+        continue;
Nit - maybe move mayHaveSideEffects() to the end here? the other tests seem much lighter (to a lesser extent - also for Loop->contains()).


More information about the llvm-commits mailing list