[PATCH] D25632: [LV] Sink scalar operands of predicated instructions

[Matthew Simpson via llvm-commits]

mssimpso added inline comments.


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:4299
+      if (!I || I->mayHaveSideEffects() || !VectorLoop->contains(I) ||
+          I->getParent() == PredBB || isa<PHINode>(I))
+        continue;
----------------
gilr wrote:
> Nit - maybe move mayHaveSideEffects() to the end here? the other tests seem much lighter (to a lesser extent - also for Loop->contains()).
> 
Sure, sounds good. I'll reorder the conditions. Thanks!


https://reviews.llvm.org/D25632