[PATCH] D24103: [peephole] Enhance folding logic to work for STATEPOINTs

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 15:45:15 PDT 2016

reames added inline comments.

Comment at: lib/CodeGen/PeepholeOptimizer.cpp:1586
-        continue;
wmi wrote:
> can we keep the continue and just let statepoint builtin to slip through? It is a little worrysome to let inlineasm or other instructions with sideeffect to try folding. 
We won't fold across anything considered a isLoadFoldBarrier().  This is handled below.  Is your concern that the folding logic might crash when folding a use into an instruction with side effects?  If so, that would seem like a separate bug we should fix. 

I am strongly resistant to special casing statepoint where generic code should work instead.  


More information about the llvm-commits mailing list