[llvm] r284435 - [AMDGPU] Mark .note section SHF_ALLOC so lld creates a segment for it

Konstantin Zhuravlyov via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 15:40:16 PDT 2016


Author: kzhuravl
Date: Mon Oct 17 17:40:15 2016
New Revision: 284435

URL: http://llvm.org/viewvc/llvm-project?rev=284435&view=rev
Log:
[AMDGPU] Mark .note section SHF_ALLOC so lld creates a segment for it

Differential Revision: https://reviews.llvm.org/D25694

Modified:
    llvm/trunk/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
    llvm/trunk/test/CodeGen/AMDGPU/hsa.ll

Modified: llvm/trunk/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp?rev=284435&r1=284434&r2=284435&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp (original)
+++ llvm/trunk/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp Mon Oct 17 17:40:15 2016
@@ -97,7 +97,8 @@ void
 AMDGPUTargetELFStreamer::EmitDirectiveHSACodeObjectVersion(uint32_t Major,
                                                            uint32_t Minor) {
   MCStreamer &OS = getStreamer();
-  MCSectionELF *Note = OS.getContext().getELFSection(".note", ELF::SHT_NOTE, 0);
+  MCSectionELF *Note =
+      OS.getContext().getELFSection(".note", ELF::SHT_NOTE, ELF::SHF_ALLOC);
 
   unsigned NameSZ = 4;
 
@@ -120,7 +121,8 @@ AMDGPUTargetELFStreamer::EmitDirectiveHS
                                                        StringRef VendorName,
                                                        StringRef ArchName) {
   MCStreamer &OS = getStreamer();
-  MCSectionELF *Note = OS.getContext().getELFSection(".note", ELF::SHT_NOTE, 0);
+  MCSectionELF *Note =
+      OS.getContext().getELFSection(".note", ELF::SHT_NOTE, ELF::SHF_ALLOC);
 
   unsigned NameSZ = 4;
   uint16_t VendorNameSize = VendorName.size() + 1;

Modified: llvm/trunk/test/CodeGen/AMDGPU/hsa.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AMDGPU/hsa.ll?rev=284435&r1=284434&r2=284435&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/AMDGPU/hsa.ll (original)
+++ llvm/trunk/test/CodeGen/AMDGPU/hsa.ll Mon Oct 17 17:40:15 2016
@@ -17,11 +17,16 @@
 ; ELF: }
 
 ; ELF: SHT_NOTE
+; ELF: Flags [ (0x2)
+; ELF: SHF_ALLOC (0x2)
+; ELF: ]
+; ELF: SectionData (
 ; ELF: 0000: 04000000 08000000 01000000 414D4400
 ; ELF: 0010: 02000000 01000000 04000000 1B000000
 ; ELF: 0020: 03000000 414D4400 04000700 07000000
 ; ELF: 0030: 00000000 00000000 414D4400 414D4447
 ; ELF: 0040: 50550000
+; ELF: )
 
 ; ELF: Symbol {
 ; ELF: Name: simple




More information about the llvm-commits mailing list