[PATCH] D25693: [AMDGPU] Emit constant address space data in .rodata section and use relocations instead of fixups (amdhsa only)

Konstantin Zhuravlyov via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 13:44:15 PDT 2016

kzhuravl added inline comments.

Comment at: lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h:59
+/// target triple \p TT, false otherwise.
+bool emitConstantsToTextSection(const Triple &TT);
tony-tye wrote:
> Would it be better to name this isEmitConstantsToTextSection or shouldEmitConstantsToTextSection since it does not actually do the emitting?
Yes, `shouldEmitConstantsToTextSection` sounds a lot better and in the same naming spirit as `shouldEmitFixup`, `shouldEmitGOTReloc`, etc. Thanks.


More information about the llvm-commits mailing list