[PATCH] D25693: [AMDGPU] Emit constant address space data in .rodata section and use relocations instead of fixups (amdhsa only)

Tony Tye via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 13:11:24 PDT 2016

tony-tye added inline comments.

Comment at: lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h:59
+/// target triple \p TT, false otherwise.
+bool emitConstantsToTextSection(const Triple &TT);
Would it be better to name this isEmitConstantsToTextSection or shouldEmitConstantsToTextSection since it does not actually do the emitting?


More information about the llvm-commits mailing list