[zorg] r284153 - Added support for ThinLTO.

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 13 14:56:12 PDT 2016


Thanks for setting up an lld ThinLTO bot. I've been meaning do so for gold,
but have no idea where to start. Does anyone have any pointers they could
send me on how to set up bots?
Thanks,
Teresa

On Thu, Oct 13, 2016, 2:46 PM Galina Kistanova via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> I am going to set it it builder definition, also I might change the
> implementation in favor of cmake option LLVM_ENABLE_LTO={THIN,FULL}, which
> I am in the middle of checking.
>
>
>  {'name' : "clang-with-thin-lto-ubuntu",
>          'slavenames' : ["ps4-buildslave1a"],
>          'builddir' : "clang-with-thin-lto-ubuntu",
>          'factory':
> ClangLTOBuilder.getClangWithLTOBuildFactory(lto='thin'),
>          'category'   : 'lld'},
>
>
> Thanks
>
> Galina
>
>
>
> On Thu, Oct 13, 2016 at 1:13 PM, Davide Italiano <davide at freebsd.org>
> wrote:
>
> On Thu, Oct 13, 2016 at 12:32 PM, Galina Kistanova via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > Author: gkistanova
> > Date: Thu Oct 13 14:32:23 2016
> > New Revision: 284153
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=284153&view=rev
> > Log:
> > Added support for ThinLTO.
> >
>
> Thanks. I may miss something, but where are you actually setting
> `-flto=thin` ?
>
> > Modified:
> >     zorg/trunk/zorg/buildbot/builders/ClangLTOBuilder.py
> >
> > Modified: zorg/trunk/zorg/buildbot/builders/ClangLTOBuilder.py
> > URL:
> http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/ClangLTOBuilder.py?rev=284153&r1=284152&r2=284153&view=diff
> >
> ==============================================================================
> > --- zorg/trunk/zorg/buildbot/builders/ClangLTOBuilder.py (original)
> > +++ zorg/trunk/zorg/buildbot/builders/ClangLTOBuilder.py Thu Oct 13
> 14:32:23 2016
> > @@ -233,6 +233,7 @@ def getClangWithLTOBuildFactory(
> >             jobs  = None,
> >             extra_configure_args = None,
> >             compare_last_2_stages = True,
> > +           lto = None, # The string gets passed to -flto flag as is.
> Like -flto=thin.
> >             env = None):
> >
> >      # Set defaults
> > @@ -305,11 +306,16 @@ def getClangWithLTOBuildFactory(
> >      # Build all the remaining stages with exactly the same
> configuration.
> >
> >      # Set proper compile and link flags.
> > +    if lto:
> > +        lto = '-flto=%s' % lto
> > +    else:
> > +        lto = '-flto'
> > +
> >      CmakeCommand.appendFlags(extra_configure_args, [
> > -        ('-DCMAKE_CXX_FLAGS=',           ['-flto']),
> > -        ('-DCMAKE_EXE_LINKER_FLAGS=',    ['-flto', '-fuse-ld=lld']),
> > -        ('-DCMAKE_MODULE_LINKER_FLAGS=', ['-flto', '-fuse-ld=lld']),
> > -        ('-DCMAKE_SHARED_LINKER_FLAGS=', ['-flto', '-fuse-ld=lld']),
> > +        ('-DCMAKE_CXX_FLAGS=',           [lto]),
> > +        ('-DCMAKE_EXE_LINKER_FLAGS=',    [lto, '-fuse-ld=lld']),
> > +        ('-DCMAKE_MODULE_LINKER_FLAGS=', [lto, '-fuse-ld=lld']),
> > +        ('-DCMAKE_SHARED_LINKER_FLAGS=', [lto, '-fuse-ld=lld']),
> >          ])
> >
> >      # The rest are test stages, which depend on the staged compiler we
> are ultimately after.
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
> --
> Davide
>
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161013/d4c4da84/attachment.html>


More information about the llvm-commits mailing list