Thanks for setting up an lld ThinLTO bot. I've been meaning do so for gold, but have no idea where to start. Does anyone have any pointers they could send me on how to set up bots? <div>Thanks,</div><div>Teresa<br><br><div class="gmail_quote"><div dir="ltr">On Thu, Oct 13, 2016, 2:46 PM Galina Kistanova via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg"><div class="gmail_msg"><div class="gmail_msg"><span style="font-family:monospace,monospace" class="gmail_msg">I am going to set it it builder definition, also I might change the implementation in favor of cmake option LLVM_ENABLE_LTO={THIN,FULL}, which I am in the middle of checking.<br class="gmail_msg"><br class="gmail_msg"></span></div><span style="font-family:monospace,monospace" class="gmail_msg"></span><span style="font-family:monospace,monospace" class="gmail_msg"></span></div><span style="font-family:monospace,monospace" class="gmail_msg"></span><span style="font-family:monospace,monospace" class="gmail_msg"></span><br class="gmail_msg"><span style="font-family:monospace,monospace" class="gmail_msg"></span><div class="gmail_msg"><div class="gmail_msg"><span style="font-family:monospace,monospace" class="gmail_msg"> {'name' : "clang-with-thin-lto-ubuntu",<br class="gmail_msg">         'slavenames' : ["ps4-buildslave1a"],<br class="gmail_msg">         'builddir' : "clang-with-thin-lto-ubuntu",<br class="gmail_msg">         'factory': ClangLTOBuilder.getClangWithLTOBuildFactory(lto='thin'),<br class="gmail_msg">         'category'   : 'lld'},<br class="gmail_msg"><br class="gmail_msg"><br class="gmail_msg"></span></div><div class="gmail_msg"><span style="font-family:monospace,monospace" class="gmail_msg">Thanks<br class="gmail_msg"><br class="gmail_msg"></span></div></div></div><div dir="ltr" class="gmail_msg"><div class="gmail_msg"><div class="gmail_msg"><span style="font-family:monospace,monospace" class="gmail_msg">Galina<br class="gmail_msg"></span></div><div class="gmail_msg"><span style="font-family:monospace,monospace" class="gmail_msg"><br class="gmail_msg"><br class="gmail_msg"></span></div></div></div><div dir="ltr" class="gmail_msg"><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">On Thu, Oct 13, 2016 at 1:13 PM, Davide Italiano <span dir="ltr" class="gmail_msg"><<a href="mailto:davide@freebsd.org" class="gmail_msg" target="_blank">davide@freebsd.org</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="gmail_msg">On Thu, Oct 13, 2016 at 12:32 PM, Galina Kistanova via llvm-commits<br class="gmail_msg">
<<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg">
> Author: gkistanova<br class="gmail_msg">
> Date: Thu Oct 13 14:32:23 2016<br class="gmail_msg">
> New Revision: 284153<br class="gmail_msg">
><br class="gmail_msg">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=284153&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=284153&view=rev</a><br class="gmail_msg">
> Log:<br class="gmail_msg">
> Added support for ThinLTO.<br class="gmail_msg">
><br class="gmail_msg">
<br class="gmail_msg">
</span>Thanks. I may miss something, but where are you actually setting `-flto=thin` ?<br class="gmail_msg">
<div class="m_4494282916438466261HOEnZb gmail_msg"><div class="m_4494282916438466261h5 gmail_msg"><br class="gmail_msg">
> Modified:<br class="gmail_msg">
>     zorg/trunk/zorg/buildbot/builders/ClangLTOBuilder.py<br class="gmail_msg">
><br class="gmail_msg">
> Modified: zorg/trunk/zorg/buildbot/builders/ClangLTOBuilder.py<br class="gmail_msg">
> URL: <a href="http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/ClangLTOBuilder.py?rev=284153&r1=284152&r2=284153&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/ClangLTOBuilder.py?rev=284153&r1=284152&r2=284153&view=diff</a><br class="gmail_msg">
> ==============================================================================<br class="gmail_msg">
> --- zorg/trunk/zorg/buildbot/builders/ClangLTOBuilder.py (original)<br class="gmail_msg">
> +++ zorg/trunk/zorg/buildbot/builders/ClangLTOBuilder.py Thu Oct 13 14:32:23 2016<br class="gmail_msg">
> @@ -233,6 +233,7 @@ def getClangWithLTOBuildFactory(<br class="gmail_msg">
>             jobs  = None,<br class="gmail_msg">
>             extra_configure_args = None,<br class="gmail_msg">
>             compare_last_2_stages = True,<br class="gmail_msg">
> +           lto = None, # The string gets passed to -flto flag as is. Like -flto=thin.<br class="gmail_msg">
>             env = None):<br class="gmail_msg">
><br class="gmail_msg">
>      # Set defaults<br class="gmail_msg">
> @@ -305,11 +306,16 @@ def getClangWithLTOBuildFactory(<br class="gmail_msg">
>      # Build all the remaining stages with exactly the same configuration.<br class="gmail_msg">
><br class="gmail_msg">
>      # Set proper compile and link flags.<br class="gmail_msg">
> +    if lto:<br class="gmail_msg">
> +        lto = '-flto=%s' % lto<br class="gmail_msg">
> +    else:<br class="gmail_msg">
> +        lto = '-flto'<br class="gmail_msg">
> +<br class="gmail_msg">
>      CmakeCommand.appendFlags(extra_configure_args, [<br class="gmail_msg">
> -        ('-DCMAKE_CXX_FLAGS=',           ['-flto']),<br class="gmail_msg">
> -        ('-DCMAKE_EXE_LINKER_FLAGS=',    ['-flto', '-fuse-ld=lld']),<br class="gmail_msg">
> -        ('-DCMAKE_MODULE_LINKER_FLAGS=', ['-flto', '-fuse-ld=lld']),<br class="gmail_msg">
> -        ('-DCMAKE_SHARED_LINKER_FLAGS=', ['-flto', '-fuse-ld=lld']),<br class="gmail_msg">
> +        ('-DCMAKE_CXX_FLAGS=',           [lto]),<br class="gmail_msg">
> +        ('-DCMAKE_EXE_LINKER_FLAGS=',    [lto, '-fuse-ld=lld']),<br class="gmail_msg">
> +        ('-DCMAKE_MODULE_LINKER_FLAGS=', [lto, '-fuse-ld=lld']),<br class="gmail_msg">
> +        ('-DCMAKE_SHARED_LINKER_FLAGS=', [lto, '-fuse-ld=lld']),<br class="gmail_msg">
>          ])<br class="gmail_msg">
><br class="gmail_msg">
>      # The rest are test stages, which depend on the staged compiler we are ultimately after.<br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> _______________________________________________<br class="gmail_msg">
> llvm-commits mailing list<br class="gmail_msg">
> <a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
<br class="gmail_msg">
</div></div><span class="m_4494282916438466261HOEnZb gmail_msg"><font color="#888888" class="gmail_msg">--<br class="gmail_msg">
Davide<br class="gmail_msg">
<br class="gmail_msg">
"There are no solved problems; there are only problems that are more<br class="gmail_msg">
or less solved" -- Henri Poincare<br class="gmail_msg">
</font></span></blockquote></div><br class="gmail_msg"></div></div>
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div></div>