[PATCH] D23252: [ADT] Zip range adapter

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 23:12:18 PDT 2016


No, perhaps not. If we figure out the constructor issue eventually we can
always fix it up later. Feel free to commit when you're satisfied

On Tue, Oct 11, 2016 at 11:01 PM bryant <3.14472+reviews.llvm.org at gmail.com>
wrote:

> bryant added a comment.
>
> The two main problems are that:
>
> 1. `apply_tuple` is defined at the bottom of the file which necessitates
> some very large forward decls.
> 2. I don't know of a direct way to invoke apply on a ctor without a
> wrapper func.
>
> If the entire patch were moved to the bottom, then the clunky decls could
> be left out. However, zip would be separated from the rest of the iterator
> adapter definitions. Do you think this is a worthwhile adjustment?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D23252
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161012/aceec170/attachment.html>


More information about the llvm-commits mailing list