No, perhaps not. If we figure out the constructor issue eventually we can always fix it up later. Feel free to commit when you're satisfied <br><br><div class="gmail_quote"><div dir="ltr">On Tue, Oct 11, 2016 at 11:01 PM bryant <<a href="mailto:3.14472%2Breviews.llvm.org@gmail.com">3.14472+reviews.llvm.org@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">bryant added a comment.<br class="gmail_msg">
<br class="gmail_msg">
The two main problems are that:<br class="gmail_msg">
<br class="gmail_msg">
1. `apply_tuple` is defined at the bottom of the file which necessitates some very large forward decls.<br class="gmail_msg">
2. I don't know of a direct way to invoke apply on a ctor without a wrapper func.<br class="gmail_msg">
<br class="gmail_msg">
If the entire patch were moved to the bottom, then the clunky decls could be left out. However, zip would be separated from the rest of the iterator adapter definitions. Do you think this is a worthwhile adjustment?<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Repository:<br class="gmail_msg">
rL LLVM<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D23252" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D23252</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>